[AND-243] Save attachments on attachment picker dismiss #5554
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Add an additional configuration flag to
AttachmentsPickerTheme(compose)
andAttachmentsPickerDialogStyle(xml)
:saveAttachmentsOnDismiss
which configures the whether the selected attachments should be 'saved' and added to the composer, if the user dismisses the picker. The idea is to prevent the 'loss' of attachments, if a user accidentally dismisses the picker after selecting one or more attachments. (Defaults tofalse
, to persist the current default behaviour, where the selected attachments are dismissed if the picker is dismissed)🛠 Implementation details
saveAttachmentsOnDismiss
flag inAttachmentsPickerTheme(compose)
saveAttachmentsOnDismiss
flag inAttachmentsPickerDialogStyle(xml)
Usage
Compose:
XML:
🎨 UI Changes
Add relevant screenshots
compose.mp4
xml.mp4
🧪 Testing
Patch