Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: apply themev2 for channel list #275

Merged
merged 1 commit into from
May 11, 2022
Merged

Conversation

szuperaz
Copy link
Contributor

@szuperaz szuperaz commented May 9, 2022

Changes in stream-chat-css: GetStream/stream-chat-css#83

@szuperaz szuperaz force-pushed the channel-list-poc branch from 7e79d37 to 2fd4201 Compare May 9, 2022 12:42
@@ -0,0 +1,13 @@
#root {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chat UI layout controlled by integrator (not by stream-chat-css)

title: Themeing and CSS v2
---

import ChannelPreviewThemeScreenshot1 from "../assets/channel-preview-theme1-screenshot.png";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all screenshots will be updated once theming is done

- Border radiuses
- Spacing (makes the chat UI more spacious/compact)

The full list of theme variables (TODO: provide a better list with descriptions)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to research if there is a way to generate docs for SCSS variables based on doc comments

Copy link
Contributor

@petyosi petyosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@szuperaz szuperaz force-pushed the channel-list-poc branch from 5c8618b to 2f45805 Compare May 11, 2022 10:19
@szuperaz szuperaz merged commit d760ed6 into theming-v2 May 11, 2022
@szuperaz szuperaz deleted the channel-list-poc branch May 11, 2022 10:27
@szuperaz
Copy link
Contributor Author

🎉 This PR is included in version 4.0.0-theming-v2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@szuperaz
Copy link
Contributor Author

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants