[Docs]Create UIKit tutorial for AudioRooms #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Great stuff, really nice to see it works well with UIKit 👍
Few general remarks:
- code should compile by copy-pasting, and I think we use some internal UIKit extensions in several places.
- in some places code can be split up in more descriptive method names.
- we should add the project to the examples repo.
martinmitrevski
approved these changes
Aug 2, 2023
There was a problem hiding this comment.
Great work @ipavlidakis 👏 Just one small thing - let's not use the concrete values for the setup of the client, but the REPLACE_WITH strings, since we reference them below.
No need for a re-review, just merge it after you apply this change.
ipavlidakis
force-pushed
the
doc/audio-rooms-with-uikit-tutorial
branch
from
b239490
to
cb2ef74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Provide all JIRA tickets and/or GitHub issues related to this PR, if applicable.
🎯 Goal
Describe why we are making this change.
📝 Summary
Provide bullet points with the most important changes in the codebase.
🛠 Implementation
Provide a detailed description of the implementation and explain your decisions if you find them relevant.
🎨 Showcase
Add relevant screenshots and/or videos/gifs to easily see what this PR changes, if applicable.
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-08-01.at.19.36.10.mp4
🧪 Manual Testing Notes
Explain how this change can be tested manually, if applicable.
☑️ Contributor Checklist
🎁 Meme
Provide a funny gif or image that relates to your work on this pull request. (Optional)