-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pinning users #133
Pinning users #133
Conversation
…into screensharing
…into broadcasting
…into broadcasting
Generated by 🚫 Danger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@@ -25,7 +25,8 @@ | |||
"testTargets" : [ | |||
{ | |||
"skippedTests" : [ | |||
"CallCRUDTest\/test_muteAllUsers()" | |||
"CallCRUDTest\/test_muteAllUsers()", | |||
"CallCRUDTest\/test_pinAndUnpinUser()" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are we skipping it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not deployed everywhere atm 😁 Slack for more info
Kudos, SonarCloud Quality Gate passed! |
🎯 Goal
Allow both local and remote pinning of users.
🛠 Implementation
🧪 Manual Testing Notes
Explain how this change can be tested manually, if applicable.
☑️ Contributor Checklist
🎁 Meme