Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps actionpack from 7.0.8.5 to 7.0.8.7 #80

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 21, 2025

See discussion below and rails/rails#54264 – we also locked concurrent-ruby to < 1.3.5 as

the concurrent-ruby gem's version 1.3.5 no longer loads the logger gem which breaks the internal logic of the ActiveSupport::LoggerThreadSafeLevel module.

Bumps actionpack from 7.0.8.5 to 7.0.8.7.

Release notes

Sourced from actionpack's releases.

7.0.8.7

Active Support

  • No changes.

Active Model

  • No changes.

Active Record

  • No changes.

Action View

  • No changes.

Action Pack

  • Add validation to content security policies to disallow spaces and semicolons. Developers should use multiple arguments, and different directive methods instead.

    [CVE-2024-54133]

    Gannon McGibbon

Active Job

  • No changes.

Action Mailer

  • No changes.

Action Cable

  • No changes.

Active Storage

  • No changes.

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jan 21, 2025
@michael-gratton
Copy link
Contributor

CI failure seems to be due to: rails/rails#54264 (comment)

@michael-gratton
Copy link
Contributor

Also:

You can point to the 7-0-stable branch. Rails 7.0 isn't supported anymore for bug fixes, so a release including that change is very unlikely https://rubyonrails.org/maintenance

@ivanb777 ivanb777 changed the title Bump actionpack from 7.0.8.5 to 7.0.8.7 Upgrade Rails to 7.1.5.1 Feb 5, 2025
@ivanb777 ivanb777 force-pushed the dependabot/bundler/actionpack-7.0.8.7 branch 2 times, most recently from ae7df68 to 7b41bc0 Compare February 5, 2025 04:00
@michael-gratton
Copy link
Contributor

@ivanb777 from memory there were some issues preventing id itself being upgraded to Rails 7.1, I'm not sure we want to do that here until that has been done first?

@ivanb777
Copy link
Contributor

ivanb777 commented Feb 5, 2025

@michael-gratton hey thanks for that – I did wonder about it as there were no PRs to bump rails in Id.
I ran a manual sync tests locally with pinning this branch, and there were no complaints, at least at this point.

I'll point to the 7-0-stable branch for now...

@michael-gratton
Copy link
Contributor

FWIW this was the approach I was taking instead: GetUp/identity-kooragang@708304a

Bumps [actionpack](https://github.com/rails/rails) from 7.0.8.5 to 7.0.8.7.
- [Release notes](https://github.com/rails/rails/releases)
- [Changelog](https://github.com/rails/rails/blob/v8.0.1/actionpack/CHANGELOG.md)
- [Commits](rails/rails@v7.0.8.5...v7.0.8.7)

---
updated-dependencies:
- dependency-name: actionpack
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@ivanb777
Copy link
Contributor

ivanb777 commented Feb 5, 2025

FWIW this was the approach I was taking instead: GetUp/identity-kooragang@708304a

thanks for that, I'll apply the same approach here for consistency

@ivanb777 ivanb777 force-pushed the dependabot/bundler/actionpack-7.0.8.7 branch from 7b41bc0 to bc44854 Compare February 5, 2025 05:27
@ivanb777 ivanb777 changed the title Upgrade Rails to 7.1.5.1 Bumps actionpack from 7.0.8.5 to 7.0.8.7 Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants