Fix of #547 #557
Merged
Fix of #547 #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ways true and it did not solve problem.
…ways true and it did not solve problem.
|
This honestly makes more sense to me than the initial PR code did to me. I've asked the author of the initial PR what they think of it. |
|
I've got a response back and they confirmed that this is the correct fix. Thanks for correcting this. |
Tim203
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous commit check if channel is opened but in that point the channel is always opened.
The ReflectionUtils.invoke() can become closed.
Solution finded with debugging and testing. I print when channel become closed and now work correctly