Populate username from sociallogin

[smcgu]

This should resolve #576.

It prioritizes the username from data and uses sociallogin as the fallback.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.97%. Comparing base (f727e27) to head (0449122).
Report is 5 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #577   +/-   ##
=======================================
  Coverage   91.97%   91.97%           
=======================================
  Files         323      323           
  Lines       18690    18690           
=======================================
  Hits        17190    17190           
  Misses       1500     1500           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[chrismaddalena]

As discussed in Slack, the changes look OK but will need some testing. I tried the change with Google auth, which caused the account name and username to be set to Google User and googleuser, respectively. There's probably an easy change to fix your issue with Open ID and Jump Cloud while keeping the same desirable functionality with Microsoft, Google, and others. I will look into it more this week.

[smcgu]

This change should only affect the username, so I think this indicates there may be a bug with the subsequent code under populate_user. Can you share an example of what data contains for one of these other providers?

Nothing jumps out to me on where username would be used for the user name.

I'll see if I can test one of these other providers locally, too.

[smcgu]

Tested Ok with GitHub OAuth.

data: {'email': None, 'username': 'smcgu', 'name': 'Sean'}

[smcgu]

How is your Google OAuth app set up? I just tested on my end and the name turned out okay. The username ended up being the Google account's first/given name. So, I'll update this PR in a few with a fallback to use to the first part of the email address.

data: {'email': '[email protected]', 'last_name': 'Doe', 'first_name': 'John'}
extra_data: {'iss': 'https://accounts.google.com', 'azp': '...', 'a
ud': '...', 'sub': '...', 'email': '[email protected]', 'email_verified': True, 'at_hash': '...', 'name': 'John Doe', 'picture': '...', 'given_name': 'John', 'family_name': 'Doe'
, 'iat': ..., 'exp': ...}

In this case, the Ghostwriter user was created with the following:

• Full Name: John Doe
• Username: john
• Email: [email protected]

[smcgu]

How is your Google OAuth app set up? I just tested on my end and the name turned out okay. The username ended up being the Google account's first/given name. So, I'll update this PR in a few with a fallback to use to the first part of the email address.

data: {'email': '[email protected]', 'last_name': 'Doe', 'first_name': 'John'}
extra_data: {'iss': 'https://accounts.google.com', 'azp': '...', 'a
ud': '...', 'sub': '...', 'email': '[email protected]', 'email_verified': True, 'at_hash': '...', 'name': 'John Doe', 'picture': '...', 'given_name': 'John', 'family_name': 'Doe'
, 'iat': ..., 'exp': ...}

In this case, the Ghostwriter user was created with the following:

* Full Name: John Doe
* Username: john
* Email: [[email protected]](mailto:[email protected])

The updated commit results now in the Ghostwriter user being:

• Full Name: John Doe
• Username: john.doe
• Email: [email protected]

[chrismaddalena]

Thanks for taking a crack at that. As mentioned in Slack, it was a temporary issue on Google's end. With no change, I stopped receiving "Google User" as an account name when I started testing this morning, so I have to imagine it was on Google's side. I have tested your latest changes and everything looks good. I'll merge it for the next release.