Projects with $0 in qf round matching show matching funds coming soon

[RamRamez]

• Projects with $0 in QF round matching show "matching funds coming soon..." message instead of $0  #4613

Summary by CodeRabbit

• New Features

  • Enhanced visual representation of the recurring donation tab in the DonationCard component.
  • Added conditional rendering for the IconSpark component in the recurring donation tab.

• Bug Fixes

  • Improved logic for determining undistributed funds in the ProjectTotalFundCard component.

• Chores

  • Updated project version from 2.33.1 to 2.33.2 in the package.json file.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
giveth-dapps-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 7, 2024 9:38pm

[coderabbitai]

Walkthrough

The pull request includes updates to the package.json file, specifically changing the project version from "2.33.1" to "2.33.2". Additionally, modifications were made to two React components: DonationCard and ProjectTotalFundCard. The DonationCard component now imports IconSpark and semanticColors, updates the Tab styled component for better layout, and conditionally renders an IconSpark. The ProjectTotalFundCard component refines the logic for determining the notDistributedFund variable to include an additional condition.

Changes

File Path	Change Summary
package.json	Updated version from "2.33.1" to "2.33.2"
src/components/views/donate/DonationCard.tsx	Added imports for IconSpark and semanticColors, updated Tab styled component for layout, conditionally rendered IconSpark.
src/components/views/project/projectDonations/ProjectTotalFundCard.tsx	Refined logic for notDistributedFund variable to include additional condition.

Possibly related PRs

• Merge Main to develop #4242: This PR also updates the package.json file, changing the version number, which is directly related to the version update in the main PR.
• Merge Main to Develop #4299: Similar to the main PR, this PR updates the package.json file to reflect a new version number.
• Main #4318: This PR updates the package.json file, changing the version from "2.28.0" to "2.28.1", which is related to the version update in the main PR.
• Main #4340: This PR updates the package.json file to change the version from "2.28.0" to "2.28.1", which is related to the version update in the main PR.
• merge main to dev #4800: This PR updates the package.json file to reflect a version change from 2.32.1 to 2.32.2, which is related to the version update in the main PR.

Suggested reviewers

• Meriem-BM
• kkatusic

Poem

🐇 In the garden of code, we hop with glee,
A version updated, as bright as can be!
With IconSpark shining, and tabs that align,
Donations are clearer, our logic refined.
So let’s celebrate this with a joyful cheer,
For every small change brings us closer, my dear! 🌼

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 150a319 and 3ebbbaf.

📒 Files selected for processing (3)

• package.json (1 hunks)
• src/components/views/donate/DonationCard.tsx (3 hunks)
• src/components/views/project/projectDonations/ProjectTotalFundCard.tsx (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• package.json

🧰 Additional context used

🔇 Additional comments (2)

src/components/views/donate/DonationCard.tsx (2)

8-9: LGTM: New imports added correctly.

The new imports for IconSpark and semanticColors from @giveth/ui-design-system are correctly added and align with the changes made in the component.

---

293-294: LGTM: Improved Tab layout.

The addition of display: flex and align-items: center to the Tab styled component improves the layout and alignment of the tab content, which is especially important with the new icon.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Caution

Inline review comments failed to post

Actionable comments posted: 2

🧹 Outside diff range and nitpick comments (1)

src/components/views/donate/DonationCard.tsx (1)

197-200: LGTM: Icon added to recurring donation tab.

The addition of the IconSpark component enhances the visual representation of the recurring donation tab. The use of semanticColors.golden[500] maintains consistency with the design system.

Consider adding a small margin-left to the icon to improve spacing:

 <IconSpark
   size={28}
   color={semanticColors.golden[500]}
+  style={{ marginLeft: '4px' }}
 />

🛑 Comments failed to post (2)

src/components/views/donate/DonationCard.tsx (1)

197-200: 🛠️ Refactor suggestion

Consider adding a tooltip to explain the spark icon.

The addition of the spark icon enhances the visual representation of the recurring donation tab. However, its meaning might not be immediately clear to all users.

Consider adding a tooltip to explain the significance of the spark icon:

 <IconSpark
   size={28}
   color={semanticColors.golden[500]}
+  title={formatMessage({ id: 'tooltip.recurring_donation_matching' })}
 />

Don't forget to add the corresponding message to your internationalization file:

{
  "tooltip.recurring_donation_matching": "Recurring donations are eligible for matching funds"
}

src/components/views/project/projectDonations/ProjectTotalFundCard.tsx (1)

60-62: 🛠️ Refactor suggestion

Simplify the notDistributedFund condition

The current condition for notDistributedFund includes a redundant check. The line qfRoundHistory?.matchingFund !== 0 is unnecessary because:

1. If qfRoundHistory?.matchingFund is 0, the first condition !qfRoundHistory?.matchingFund would already be true.
2. If qfRoundHistory?.matchingFund is not 0, the first condition would be false, making the second check unnecessary.

Consider simplifying the condition to:

const notDistributedFund = !qfRoundHistory?.matchingFund && !selectedQF?.isActive;

This change maintains the same logic while improving readability and reducing potential confusion.