Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

applet.program.avr: improve CLI experience for memory arguments #624

Merged

Conversation

whitequark
Copy link
Member

Before this commit, it was not clear that the filename suffix determines the file format. After this commit this is made clear in the text, and also invalid filenames are rejected at argument parsing stage.

Inspired by, and supersedes, #623.

Copy link
Contributor

@collinmay collinmay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this approach overall

software/glasgow/applet/program/avr/__init__.py Outdated Show resolved Hide resolved
whitequark and others added 2 commits July 21, 2024 21:07
Before this commit, it was not clear that the filename suffix determines
the file format. After this commit this is made clear in the text, and
also invalid filenames are rejected at argument parsing stage.

Co-authored-by: Collin May <[email protected]>
@whitequark whitequark force-pushed the applet.program.avr/improve-cli branch from c6dbb6a to 6d0e30c Compare July 21, 2024 21:08
@whitequark whitequark added this pull request to the merge queue Jul 21, 2024
@whitequark
Copy link
Member Author

Thanks for the review!

@whitequark
Copy link
Member Author

@collinmay Would you be up for doing some maintenance work on Glasgow? We're really low on people who can do that unfortunately, and I'd like to change that.

Merged via the queue into GlasgowEmbedded:main with commit 7ad0533 Jul 21, 2024
20 checks passed
@whitequark whitequark deleted the applet.program.avr/improve-cli branch July 21, 2024 21:27
@collinmay
Copy link
Contributor

I'd be happy to pick a few applets off #599 (good excuse for me to learn a new HDL!), but can't commit to any kind of long-term maintenance. I'm super impressed with this platform and am currently pushing for my employer to buy a few Glasgow units and use them in our work. I'll make my best effort to upstream any fixes we might come up with :)

@whitequark
Copy link
Member Author

I'd be happy to pick a few applets off #599 (good excuse for me to learn a new HDL!), but can't commit to any kind of long-term maintenance.

That's perfectly fine. I wasn't always skilled enough in communication to take advantage of this, but a few applets here and there can really make a difference at this point.

I'm super impressed with this platform and am currently pushing for my employer to buy a few Glasgow units and use them in our work. I'll make my best effort to upstream any fixes we might come up with :)

Nice! In my mind, we're just getting started, and I'm going to improve the software/gateware integration to be on a whole next level at some point in the next few years.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants