-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
applet.program.avr: improve CLI experience for memory arguments #624
applet.program.avr: improve CLI experience for memory arguments #624
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with this approach overall
Before this commit, it was not clear that the filename suffix determines the file format. After this commit this is made clear in the text, and also invalid filenames are rejected at argument parsing stage. Co-authored-by: Collin May <[email protected]>
c6dbb6a
to
6d0e30c
Compare
Thanks for the review! |
@collinmay Would you be up for doing some maintenance work on Glasgow? We're really low on people who can do that unfortunately, and I'd like to change that. |
I'd be happy to pick a few applets off #599 (good excuse for me to learn a new HDL!), but can't commit to any kind of long-term maintenance. I'm super impressed with this platform and am currently pushing for my employer to buy a few Glasgow units and use them in our work. I'll make my best effort to upstream any fixes we might come up with :) |
That's perfectly fine. I wasn't always skilled enough in communication to take advantage of this, but a few applets here and there can really make a difference at this point.
Nice! In my mind, we're just getting started, and I'm going to improve the software/gateware integration to be on a whole next level at some point in the next few years. |
Before this commit, it was not clear that the filename suffix determines the file format. After this commit this is made clear in the text, and also invalid filenames are rejected at argument parsing stage.
Inspired by, and supersedes, #623.