examples.boilerplate: modify to use port groups #663
Conversation
examples/boilerplate.py
Outdated
| @classmethod | ||
| def add_build_arguments(cls, parser, access): | ||
| super().add_build_arguments(parser, access) | ||
|
|
||
| for pin in cls.__pins: | ||
| access.add_pin_argument(parser, pin, default=True) | ||
| access.add_pin_argument(parser, "example", default=True) |
There was a problem hiding this comment.
Maybe call it something like data instead?
|
This is an idea for an expanded boilerplate applet that shows how to use in and out fifos and ports; feel free to ignore and we can go back to the previous commit and just use "data" instead of "example". |
examples/boilerplate.py
Outdated
| ## Connect BoilerplateModule.in_stream to BoilerplateSubtarget.out_fifo | ||
| boilerplate.in_stream.payload.eq(self.out_fifo.r_data), | ||
| boilerplate.in_stream.valid.eq(self.out_fifo.r_rdy), | ||
| self.out_fifo.r_en.eq(boilerplate.in_stream.ready), |
There was a problem hiding this comment.
I think you should be able to do these via wiring.connect too, but I may not have upstreamed that patch yet...
There was a problem hiding this comment.
In my latest version, I used the "interface adaptation" pattern between the in/out fifo signals to a stream.Signature. But I see now that amaranth.lib.fifo implements streams, so out_fifo.r_stream and in_fifo.w_stream should just work.
examples/boilerplate.py
Outdated
|
|
||
| ## Instantiate IO buffers for pins/ports | ||
| m.submodules.data_buffer = data_buffer = io.Buffer("i", args.port_data) | ||
| m.submodules.enable_buffer = enable_buffer = io.Buffer("o", args.port_enable) |
There was a problem hiding this comment.
Conceptually these should live in the BoilerplateModule which I'd probably call BoilerplateCore. So the core would do the port manipulation and the subtarget would set up the transfers and stuff like that, right?
There was a problem hiding this comment.
That separation of functions makes sense to me. A more verbose option would be to create a BoilerplateOutput module to handle the ports, and then leave BoilerplateCore empty as a placeholder for "core" logic.
There was a problem hiding this comment.
That seems excessive for the sample applet. This all will change some time not too far away anyway.
isabelburgos
force-pushed
the
isabelburgos/boilerplate-padless
branch
from
8b6fc89
to
05b4346
Compare
Follow up to #599 - replacement of
padswithports.Added an "example" pin to demonstrate
get_port_groupssyntax, although this feels clunky compared to the previous boilerplate which had no pins.