Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sparse array operations to main development branch #351

Open
wants to merge 134 commits into
base: develop
Choose a base branch
from

Conversation

bjpalmer
Copy link
Member

Support for sparse distributed 2D arrays has been added to the repository. This includes support for setting up and distributing arrays and basic operations such as matrix-vector and matrix-matrix multiplies.

bjpalmer and others added 30 commits October 29, 2021 11:22
…se that

solves Laplace's equation using a conjugate gradient algorithm.
solution. This can be visualized using something like VisIt or Paraview.
to compare Kaczmarz solution to conjugate gradient.
distribution to block distribution and cleaned up output to VTK file.
@edoapra
Copy link
Contributor

edoapra commented Sep 14, 2024

@bjpalmer Did you rebase this branch correctly? There is a huge number of changes here ... are they all needed?

@edoapra
Copy link
Contributor

edoapra commented Sep 14, 2024

some failure in the github action tests

/usr/bin/ld: ../libga.a(capi.c.o): in function `NGA_Sprs_array_create':
capi.c:(.text+0x16d37): undefined reference to `pnga_sprs_array_create'

@bjpalmer
Copy link
Member Author

This is a fairly big chunk of new functionality, so I'm not surprised that there are a lot of changes. Almost all of the changes are additions to the code. I'll check up on the CI fails.

@edoapra
Copy link
Contributor

edoapra commented Sep 17, 2024

global/testing/gs_ran.x fails (it is not in the github action tests, though) with the error

Initial vector a_1

 global array: [1:8],  handle: -990 
   1       0.97563
   2       0.35161
   3      -0.42865
   4      -0.31672
   5       0.93024
   6       0.34336
   7      -0.36423
   8      -0.34972
0:length of V must equal second dimension of sparse matrix:Received an Error in Communication

@bjpalmer
Copy link
Member Author

I'm working on corrections. The gs_ran.c code does not work and I'm taking it out of the test suite.

@edoapra
Copy link
Contributor

edoapra commented Sep 17, 2024

I'm working on corrections. The gs_ran.c code does not work and I'm taking it out of the test suite.

What about sprs_test.x, kaczmarz.x and j_iter.x? They seems to be very slow tests ... any chance to speed them up?

@bjpalmer
Copy link
Member Author

I can make them smaller. I already did it for sprs_test.x and I'll look at the others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants