Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolving "Pelargonium × hortorum" causes exceptions/ errors #55

Open
dimus opened this issue Jan 24, 2017 · 5 comments
Open

resolving "Pelargonium × hortorum" causes exceptions/ errors #55

dimus opened this issue Jan 24, 2017 · 5 comments

Comments

@dimus
Copy link
Member

dimus commented Jan 24, 2017

@jhpoelen commented on Fri Dec 23 2016

When resolving "Pelargonium × hortorum" using http://resolver.globalnames.org, the following error page is shown: We're sorry, but something went wrong. We've been notified about this issue and we'll take a look at it shortly.

Original errors where observed when resolving names using the resolver api. Other examples include: Citrus × paradisi, Acer × freemanii, Malus ×domestica, Abelia × grandiflora, and Platanus × acerifolia.


@alexander-myltsev commented on Tue Jan 24 2017

This is not the issue of gnresolver. @dimus , would you figure out where to put it best?


@dimus commented on Tue Jan 24 2017

Yes, I'm moving it to gni. May be it is better to wait with this one until we have gnresolver running. @jhpoelen , how important it is for you?

We do not deal with hybrids in gnresolver yet as well :-/

@jhpoelen
Copy link

@dimus not a huge issue but generates a bunch of distracting noise and false negatives. How hard is it to fix this?

@dimus
Copy link
Member Author

dimus commented Jan 24, 2017

Hybrids add an additional level of complexity, because they match more 'fuzzy' than non-hybrids. For example if we see Pelargonium hortorum --- should we match it to xPelargonium hortorum or Pelargonium x hortorum or Pelargonium x hortorum and what about Pelargonium hortorum x P. domesticum or Pelargonium domestcum x Pelargonium hortorum? They all kind of connect to each other, but to decide how to match them requires developing robust and reasonable rules.

@jhpoelen
Copy link

jhpoelen commented Jan 24, 2017

Did you consider having a hybrid name detector and giving a little more friendly error message rather than making it seem like the server crashed? This would already be an improvement for me. Sort of like a "not yet supported" exception.

@dimus
Copy link
Member Author

dimus commented Jan 25, 2017

Yes, definitely makes sense, I'll schedule it for the next week

@bjonnh
Copy link

bjonnh commented Aug 15, 2018

Any hope to get that resolved? It seems to me that the issue here was also that the x used was a unicode × and not a x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants