Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a catch-all for NTSTATUS for error codes we don't care about #471

Merged
merged 1 commit into from
May 31, 2024

Conversation

luciaprime54
Copy link
Contributor

Some Clients can return other Error codes that we can safely ignore, such as the MacOS Windows RDP Client when transferring multiple files.

Rather than hardcode 1000s of possible Status codes Just handle the ones we need to and create a catch-all for the ones we don't care about so we don't throw an exception and crash unnecessarily.

Unfortunately I don't have the specific error code I saw on Mac (it was a while ago, and it wasn't every time), but this solution would hopefully also help if other clients do the same thing.

Copy link
Collaborator

@obilodeau obilodeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Thank you!

@obilodeau obilodeau merged commit 051f937 into GoSecure:main May 31, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants