Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent simultaneous connections #202

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Conversation

Gold872
Copy link
Owner

@Gold872 Gold872 commented Jan 22, 2025

Previously, if the IP address was changed while network tables was disconnected, there would be a new connection attempt "loop" that tried to connect at the same time as the existing connection attempt "loop(s)". When the connection was eventually established, multiple clients would be created on Network Tables.

Now, when trying to connect, any additional calls to _connect() while trying to connect will be blocked off, preventing this issue

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 75.91%. Comparing base (9dcd004) to head (f5155ef).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
lib/services/nt4_client.dart 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #202      +/-   ##
==========================================
- Coverage   75.92%   75.91%   -0.02%     
==========================================
  Files          79       79              
  Lines        8624     8626       +2     
==========================================
  Hits         6548     6548              
- Misses       2076     2078       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gold872 Gold872 merged commit bf6f698 into main Jan 22, 2025
9 checks passed
@Gold872 Gold872 deleted the prevent-simultaneous-connections branch January 22, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant