fix: nft permissions

GoodDollar · Nov 3, 2024 · 55fc34b · 55fc34b
1 parent eab546e
commit 55fc34b
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/packages/contracts/contracts/DirectPayments/DirectPaymentsFactory.sol b/packages/contracts/contracts/DirectPayments/DirectPaymentsFactory.sol
@@ -130,7 +130,6 @@ contract DirectPaymentsFactory is AccessControlUpgradeable, UUPSUpgradeable {
             pool = DirectPaymentsPool(address(new ERC1967Proxy(impl.implementation(), initCall)));
         }
 
-        nft.grantRole(nft.getManagerRole(nextNftType), _settings.manager);
         nft.grantRole(nft.getManagerRole(nextNftType), address(pool));
 
         //access control to project is determinted by the first pool access control rules

diff --git a/packages/contracts/test/DirectPayments/DirectPaymentsFactory.test.ts b/packages/contracts/test/DirectPayments/DirectPaymentsFactory.test.ts
@@ -99,7 +99,7 @@ describe('DirectPaymentsFactory', () => {
     expect(await factory.hasRole(factory.DEFAULT_ADMIN_ROLE(), signer.address)).to.be.true;
 
     expect(await nft.hasRole(nft.DEFAULT_ADMIN_ROLE(), signer.address)).to.be.true;
-    expect(await nft.hasRole(await nft.getManagerRole('1'), signers[1].address)).to.be.true;
+    expect(await nft.hasRole(await nft.getManagerRole('1'), signers[1].address)).to.be.false;
     expect(await nft.hasRole(await nft.getManagerRole('1'), pool.address)).to.be.true;
 
     expect(await pool.hasRole(pool.DEFAULT_ADMIN_ROLE(), signer.address)).to.be.true;