Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

224 new homepage #228

Merged
merged 6 commits into from
Oct 25, 2024
Merged

224 new homepage #228

merged 6 commits into from
Oct 25, 2024

Conversation

L03TJ3
Copy link
Collaborator

@L03TJ3 L03TJ3 commented Oct 11, 2024 •
edited
Loading

Description

Adding a new homepage

Todo's:

  • hook for stats
  • test mobile

About # (link your issue here)
#224

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • PR title matches follow: (Feature|Bug|Chore) Task Name
  • My code follows the style guidelines of this project
  • I have followed all the instructions described in the initial task (check Definitions of Done)
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added reference to a related issue in the repository
  • I have added a detailed description of the changes proposed in the pull request. I am as descriptive as possible, assisting reviewers as much as possible.
  • I have added screenshots related to my pull request (for frontend tasks)
  • I have pasted a gif showing the feature.
  • @mentions of the person or team responsible for reviewing proposed changes

@L03TJ3 L03TJ3 requested a review from sirpy October 20, 2024 12:19
@L03TJ3 L03TJ3 marked this pull request as ready for review October 20, 2024 12:19
sirpy
sirpy requested changes Oct 21, 2024
View reviewed changes
packages/app/src/hooks/useTotalStats.ts Show resolved Hide resolved
packages/app/src/pages/HomePage.tsx Outdated Show resolved Hide resolved
packages/app/src/theme/theme.ts Show resolved Hide resolved
packages/app/src/theme/theme.ts Outdated Show resolved Hide resolved
packages/app/src/theme/theme.ts Outdated Show resolved Hide resolved
packages/app/src/theme/theme.ts Show resolved Hide resolved
yarn.lock Show resolved Hide resolved
@L03TJ3 L03TJ3 requested a review from sirpy October 21, 2024 13:37
@L03TJ3
224 homepage with factory (#229)
0707878 
* wip: use factory instead of withTheme

* remove withTheme hook usage, add: centralize breakpoint handling

* style fixes

* fix: handle copy in ui

* add typing
@L03TJ3 L03TJ3 merged commit 0cd38ea into master Oct 25, 2024
2 checks passed
@L03TJ3 L03TJ3 deleted the 224-new-homepage branch October 25, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirpy sirpy Awaiting requested review from sirpy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@L03TJ3 @sirpy