224 homepage with factory #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sirpy so this is the pattern you want to follow? The only difference I spotted under the hood is the output of the HTML. Factory > outputs HTML with inline-styles could affect performance according to some, but in this minimal example not noticable |
L03TJ3
commented
Oct 21, 2024
L03TJ3
added a commit
that referenced
this pull request
Oct 25, 2024
* add: new homepage * add: totalStats subgraph hook * chore: mobile/responsive styles fixes * 224 homepage with factory (#229) * wip: use factory instead of withTheme * remove withTheme hook usage, add: centralize breakpoint handling * style fixes * fix: handle copy in ui * add typing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replacing withTheme hook with native-base's own Factory