Skip to content

Commit

Permalink
Dont show na_requested as a response vote. (#3534)
Browse files Browse the repository at this point in the history
  • Loading branch information
jrobbins authored Dec 6, 2023
1 parent ba0243e commit 2818780
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion client-src/elements/chromedash-gate-column.js
Original file line number Diff line number Diff line change
Expand Up @@ -741,9 +741,14 @@ export class ChromedashGateColumn extends LitElement {
`;
}

isReviewRequest(vote) {
return (vote.state === GATE_REVIEW_REQUESTED ||
vote.state === GATE_NA_REQUESTED);
}

renderVotes() {
const canVote = this.userCanVote();
const responses = this.votes.filter((v) => v.state !== GATE_REVIEW_REQUESTED);
const responses = this.votes.filter((v) => !this.isReviewRequest(v));
const responseEmails = responses.map((v) => v.set_by);
const othersPending = this.gate.assignee_emails.filter((ae) =>
!responseEmails.includes(ae) && ae != this.user?.email);
Expand Down

0 comments on commit 2818780

Please sign in to comment.