Skip to content

Commit

Permalink
Style updates
Browse files Browse the repository at this point in the history
  • Loading branch information
dlaliberte committed Dec 7, 2023
1 parent 18e9181 commit ca4cb55
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 7 deletions.
3 changes: 0 additions & 3 deletions client-src/elements/chromedash-guide-new-page.js
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ export class ChromedashGuideNewPage extends LitElement {
constructor() {
super();
this.userEmail = '';
// this.isEnterpriseFeature = false; // ??
this.fieldValues = [];
}

Expand All @@ -78,14 +77,12 @@ export class ChromedashGuideNewPage extends LitElement {

handleFormSubmit(event, hiddenTokenField) {
event.preventDefault();
// const submitBody =
formatFeatureChanges(this.fieldValues, this.featureId);

// get the XSRF token and update it if it's expired before submission
window.csClient.ensureTokenIsValid().then(() => {
hiddenTokenField.value = window.csClient.token;
event.target.submit();
// return csClient.updateFeature(submitBody);
});
}

Expand Down
8 changes: 4 additions & 4 deletions client-src/elements/utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -405,12 +405,12 @@ export function checkMilestoneStartEnd(startEndPair, getFieldValue) {
export function checkFeatureNameAndType(getFieldValue) {
const name = (getFieldValue('name') || '').toLowerCase();
const featureType = Number(getFieldValue('feature_type') || '0');
const deprecationName =
const isdeprecationName =
(name.includes('deprecat') || name.includes('remov'));
const deprecationType =
const isdeprecationType =
(featureType === FEATURE_TYPES.FEATURE_TYPE_DEPRECATION_ID[0]);
if (deprecationName !== deprecationType) {
if (deprecationName) {
if (isdeprecationName !== isdeprecationType) {
if (isdeprecationName) {
return {
warning: `If the feature name contains "deprecate" or "remove",
the feature type should be "Feature deprecation"`,
Expand Down

0 comments on commit ca4cb55

Please sign in to comment.