Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move debuggability reviewers into NDB. #3485

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

jrobbins
Copy link
Collaborator

@jrobbins jrobbins commented Nov 9, 2023

Now that I have assigned reviewers and support for rotations working, the Debuggability team also wants to have the reviewers assigned by their rotation.

In this PR:

  • Move the debuggability reviewer list out of the source code and in to NDB.
  • Change how failure to fetch the on-call person is handled: simply don't auto-assign instead of aborting the whole request.

@jrobbins jrobbins requested a review from KyleJu November 9, 2023 00:23
@jrobbins
Copy link
Collaborator Author

jrobbins commented Nov 9, 2023

Note: I already submitted CL 580271712 to enable access to the debuggability rotation on-call person's email address. It has not been deployed yet, but regardless of that, this PR can be reviewed, merged, and deployed to chromestatus on our usual schedule. The change to simply return when the rotation_url request gives a 404 means that the auto-assignments will just be a no-op until my CL gets deployed.

@jrobbins jrobbins merged commit 1dfaaf3 into main Nov 9, 2023
7 checks passed
@jrobbins jrobbins deleted the 20231108-add-debuggability-rotation branch November 9, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants