Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a menu to add xfn gates. #3539

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Conversation

jrobbins
Copy link
Collaborator

@jrobbins jrobbins commented Dec 9, 2023

This should resolve a request from the API Owners and save me from doing manual work. Sometimes a feature is created using the PSA feature type, but then it turns out to have a bigger impact than expected, so it needs cross-functional review and an intent-to-ship thread.

In this PR:

  • Add a "..." menu to the stage accordion sections with a "Add cross-functional gates" item when appropriate.
  • Add an API call to csClient and main.py for the new action.
  • Add an API handler to add the needed gates.

@jrobbins
Copy link
Collaborator Author

jrobbins commented Dec 9, 2023

I still need to add new unit tests, but you can take a look now.

@jrobbins
Copy link
Collaborator Author

jrobbins commented Dec 9, 2023

OK, ready for review.

@jrobbins jrobbins requested a review from dlaliberte December 11, 2023 21:09
Copy link
Collaborator

@dlaliberte dlaliberte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't really review the Python code, but the JavaScript seems fine, though I wonder about the use of confirm and event triggering.

@jrobbins jrobbins merged commit 97c9be0 into main Dec 12, 2023
7 checks passed
@jrobbins jrobbins deleted the 20231208-menu-item-to-add-xfn-gates branch December 12, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants