Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hyperlink on the bottom #4664

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Add hyperlink on the bottom #4664

merged 3 commits into from
Jan 8, 2025

Conversation

KyleJu
Copy link
Collaborator

@KyleJu KyleJu commented Jan 3, 2025

A follow-up for #4658. Link selected feature group to webstatus.dev.

UI

Screenshot 2025-01-06 11 49 48 AM

@KyleJu KyleJu changed the title [Draft] Add hyperlink on the bottom Add hyperlink on the bottom Jan 3, 2025
@KyleJu KyleJu marked this pull request as ready for review January 3, 2025 23:54
@KyleJu KyleJu requested a review from jrobbins January 3, 2025 23:55
Copy link
Collaborator

@jrobbins jrobbins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after considering some tweaks.

client-src/elements/chromedash-form-field.ts Outdated Show resolved Hide resolved
@KyleJu
Copy link
Collaborator Author

KyleJu commented Jan 6, 2025

Note to myself: update the playwright tests before merge

@KyleJu
Copy link
Collaborator Author

KyleJu commented Jan 8, 2025

Note to myself: update the playwright tests before merge

Tried a number of test setup but still cannot get the link to show. I left a TODO and added a unit test instead. @jrobbins

@KyleJu KyleJu merged commit 70a1c9d into main Jan 8, 2025
7 checks passed
@KyleJu KyleJu deleted the link-below-input branch January 8, 2025 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants