Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send SLO reminders for review resolution #4670

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

jrobbins
Copy link
Collaborator

@jrobbins jrobbins commented Jan 6, 2025

This is progress toward implementing improved SLOs for both an initial response and a review resolution. Now that we can calculate when a review is due for a resolution, we will start sending email reminders about review resolutions that are due or overdue.

In this PR:

  • Consider all gates that have active reviews and organize any due or overdue ones into four lists: initial response due, initial response overdue, resolution due, and resolution overdue.
  • Generate four sets of email notifications based on those four lists.
  • Make the wording of the reminder email vary based on initial response vs. resolution.
  • Add unit tests and golden data files.

@jrobbins jrobbins requested a review from KyleJu January 6, 2025 23:51
@jrobbins jrobbins merged commit f5cd015 into main Jan 7, 2025
7 checks passed
@jrobbins jrobbins deleted the 20250103-send-notification-for-slo-resolve branch January 7, 2025 19:46
@jrobbins
Copy link
Collaborator Author

jrobbins commented Jan 7, 2025

This relates to #4634.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants