Automatically expand stages that have reviews in progress. #4671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KyleJu
approved these changes
Jan 7, 2025
jrobbins
deleted the
20250107-automatically-expand-stages-that-have-reviews-in-progress
branch
|
This relates to #4634. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a step toward supporting more fine-grained SLO measurements. Now that feature owners need to explicitly re-request reviews that were marked NEEDS_WORK, it is important that they can easily notice such reviews on the feature detail page.
Previously, the only open stage accordion sections were for the stage that the user had marked as active, or the stage containing a gate mentioned in the URL. Now, the app will also automatically expand any section that has a gate in an active review state, or a mixed combination of PREPARING and APPROVED gates.
In this PR: