New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Soft-delete attachments when link is removed. #4672

Merged

jrobbins merged 1 commit into main from 20250107-delete-attachments-when-link-is-removed

Jan 8, 2025

Collaborator

jrobbins commented Jan 8, 2025

This should resolve #4630.

When the user removes the link to an attachment and saves the change, the attachment itself is marked deleted (and is no longer viewable).

In this PR:

Add logic to take a post-PATCH action when the screenshot_links field is edited.
Implement a helper function to mark those attachments deleted.
Add unit tests.
Also, make the SLO reminder emails tests more robust because other tests can change the specific NDB ID numbers that occur in the URLs in the golden.


          Soft-delete attachments when link is removed.

512f889

jrobbins requested a review from KyleJu

January 8, 2025 01:45

KyleJu approved these changes

View reviewed changes

jrobbins merged commit 10fe4a2 into main

7 checks passed

jrobbins deleted the 20250107-delete-attachments-when-link-is-removed branch

January 8, 2025 20:27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet