Use the origin trial display name in trial extension emails #4679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielRyanSmith
commented
Jan 9, 2025
Comment on lines
-843
to
-850
| if feature is None: | ||
| self.abort(400, 'No feature provided.') | ||
| gate_id = self.get_param('gate_id') | ||
| if gate_id is None: | ||
| self.abort(400, 'Extension gate ID not provided.') | ||
| requester_email = self.get_param('requester_email') | ||
| if not requester_email: | ||
| self.abort(400, 'Extension requester\'s email address not provided.') |
There was a problem hiding this comment.
These abort statements were unnecessary, since the get_param method contains an abort statement in the event the parameter is not provided.
jrobbins
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a small problem where the feature name is being used in the origin trial extension emails rather than the origin trial name. The origin trial name is now passed with the email task parameters to populate the subject line in the email.