New histogram ID enum for differentiating use counter types #4703
+18
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is a follow-up to #4624 that updates the implementation to use new histogram ID enums to differentiate use counters rather than having different config types. Changes were made to the origin trials API and how it represents use counter types (histogram ID), and this change mirrors those changes.
This is not a breaking change and can be successfully deployed without request interruption between ChromeStatus and the OT API.
Note that the
css_property_idhistogram ID enum is not yet used, which will come at a later time when addressing #4702.