misc(lantern-collect): rebaseline to include new ttfb metric (#15069)

GoogleChrome · May 11, 2023 · 49aa142 · 49aa142
1 parent fbf5af5
commit 49aa142
Show file tree

Hide file tree

Showing 5 changed files with 99 additions and 82 deletions.
diff --git a/core/scripts/lantern/assert-baseline-lantern-values-unchanged.js b/core/scripts/lantern/assert-baseline-lantern-values-unchanged.js
@@ -39,6 +39,8 @@ for (const entry of computedResults.sites) {
   /** @type {DiffForSite[]} */
   const diffsForSite = [];
   Object.keys(actualLantern).forEach(metricName => {
+    if (!(metricName in expectedLantern)) throw new Error(`missing metric ${metricName}`);
+
     const actual = Math.round(actualLantern[metricName]);
     const expected = Math.round(expectedLantern[metricName]);
     const diff = actual - expected;

diff --git a/core/scripts/lantern/constants.js b/core/scripts/lantern/constants.js
@@ -48,6 +48,9 @@ import {LH_ROOT} from '../../../root.js';
  * @property {number} [timeToConsistentlyInteractive]
  * @property {number} [speedIndex]
  * @property {number} [largestContentfulPaint]
+ * @property {number} [timeToFirstByte]
+ * @property {number} [largestContentfulPaintLoadStart]
+ * @property {number} [largestContentfulPaintLoadEnd]
  */
 
 /**
@@ -67,6 +70,9 @@ import {LH_ROOT} from '../../../root.js';
  * @property {number} roughEstimateOfSI
  * @property {number} roughEstimateOfTTI
  * @property {number} roughEstimateOfLCP
+ * @property {number} roughEstimateOfTTFB
+ * @property {number} roughEstimateOfLCPLoadStart
+ * @property {number} roughEstimateOfLCPLoadEnd
  */
 
 /** @type {Array<string>} */
@@ -196,6 +202,10 @@ export default {
       roughEstimateOfSI: evaluate('speedIndex', 'roughEstimateOfSI'),
       roughEstimateOfTTI: evaluate('timeToConsistentlyInteractive', 'roughEstimateOfTTI'),
       roughEstimateOfLCP: evaluate('largestContentfulPaint', 'roughEstimateOfLCP'),
+      // TODO: enable when new traces are collected.
+      // roughEstimateOfTTFB: evaluate('timeToFirstByte', 'roughEstimateOfTTFB'),
+      // roughEstimateOfLCPLoadStart: evaluate('largestContentfulPaintLoadStart', 'roughEstimateOfLCPLoadStart'),
+      // roughEstimateOfLCPLoadEnd: evaluate('largestContentfulPaintLoadEnd', 'roughEstimateOfLCPLoadEnd'),
     };
   },
 };
diff --git a/core/scripts/lantern/print-correlations.js b/core/scripts/lantern/print-correlations.js
@@ -100,7 +100,7 @@ function evaluateAndPrintAccuracy(metric, lanternMetric) {
   const baselineOptions = {alwaysGray: !lanternMetric.includes('roughEstimate')};
 
   const strings = [
-    lanternMetric.padEnd(25),
+    lanternMetric.padEnd(28),
     `${toPercentString(actualAccuracy.p50)} ${toBaselineDiffString(
       actualAccuracy.p50,
       baselineAccuracy.p50,
@@ -216,7 +216,7 @@ function findAndPrintFixesRegressions() {
 
 console.log(
   chalk.bold(
-    'Metric'.padEnd(25),
+    'Metric'.padEnd(28),
     'p50 (% Error)'.padEnd(20),
     'p90 (% Error)'.padEnd(20),
     'p95 (% Error)'.padEnd(20)
@@ -243,6 +243,11 @@ evaluateAndPrintAccuracy('largestContentfulPaint', 'optimisticLCP');
 evaluateAndPrintAccuracy('largestContentfulPaint', 'pessimisticLCP');
 evaluateAndPrintAccuracy('largestContentfulPaint', 'roughEstimateOfLCP');
 
+// TODO: enable when new traces are collected (also, do calls to findAndPrintWorst10Sites)
+// evaluateAndPrintAccuracy('timeToFirstByte', 'roughEstimateOfTTFB');
+// evaluateAndPrintAccuracy('largestContentfulPaintLoadStart', 'roughEstimateOfLCPLoadStart');
+// evaluateAndPrintAccuracy('largestContentfulPaintLoadEnd', 'roughEstimateOfLCPLoadEnd');
+
 const estimates = allEvaluations.filter(entry => entry.lanternMetric.includes('roughEstimate'));
 const baselineEstimates = baselineEvaluations.filter(entry =>
   entry.lanternMetric.includes('roughEstimate')

diff --git a/core/scripts/lantern/update-baseline-lantern-values.js b/core/scripts/lantern/update-baseline-lantern-values.js
@@ -44,10 +44,10 @@ fs.writeFileSync(OUTPUT_PATH, prettyJSONStringify({sites}, {
   spaceBeforeColon: '',
   spaceInsideObject: '',
   shouldExpand: (_, level) => level < 2,
-}));
+}) + '\n');
 
 fs.writeFileSync(OUTPUT_ACCURACY_PATH, JSON.stringify(
   constants.evaluateAllMetrics(computedResults, {sites}),
   null,
   2
-));
+) + '\n');