Download images plugin Issue#480 #491
Conversation
There was a problem hiding this comment.
Yay, PR to a PR, so fun! Ty!
- Looks like you have a linter that went and formatted a bunch of CSS files. Can you remove those commits from the PR please 🙂
- The updates to package json and the package lock files, can you remove those commits as well
I ran a developer edition of visbug and used the script on some pages, it mostly went great! See the above change requests and let's chat about how to resolve the ux issue i had. Thanks 🙂
| try { | ||
| console.log(`Fetching ${url}`) | ||
| const response = await fetch(url) |
There was a problem hiding this comment.
I think we need to do some modifying of image urls too, like we are with css urls. I ran the plugin on css-tricks.com and the script did not properly download everything. It missed over half. Still exciting to see it at work though. Things like ads, that are secure and serve once, I'm totally cool with not downloading. But avatars and other stuff, I def expect those to be in my folder, and they're currently missing for ~40% of css-tricks.com right now.
I didnt dig into it too deep, but it was urls like this one https://secure.gravatar.com/avatar/8081b26e05bb4354f7d65ffc34cbbd67?s=80&d=retro&r=pg that didnt download.
There was a problem hiding this comment.
okay @argyleink le me check for it and i'll update you with that tomorrow... now i have some important work to finish off.
There was a problem hiding this comment.
hey @argyleink I have used the same url and it downloaded the image.
check the screenshots i have attached.
There was a problem hiding this comment.
i'll look into this further and see what's going on different on css-tricks.com than the visbug test page.
|
closing since the work was merged in #492 |
Oh :( Is there any other issue suitable for me. |
|
yep definitely! you can also see the current state of the plugin ux at the branch here #481, and it's not done yet! maybe you want to help finish it off? it's currently stuck at failing about 30% of images when run on real sites. You'll need to install the extension locally and run it on a webpage like css-tricks, to get the more "real world" set of urls. it's very very close! but when you run it, there's a few visual images that dont download, and it's due to either bad fetch urls, or bad names we try to write to disk. still trying to iron out all the frayed edges so this thing is pretty dependable and smooth. thanks for all the help so far! |
|
hey @argyleink sorry for late reply actually i got a project to do... so i was busy in that. ya some images are not downloading i guess the reason could be the images from local folder. like the URL can be "./assets/images/photo.jpeg" now in this case we can't get that image. |
|
totally. there's a few cases we can't handle, totally cool with that, but it feels like too many are failing. especially since i can go find the url and open it in my browser. sometimes it's the name it tries to create on file is invalid, which makes sense, that logic is getting complex. i figure we can widdle away at the few easy wins, and then merge it? i'd like it to be a bit more reliable. thoughts? |
ya if it is failing too many of images then its not good at all. |
|
I havent grabbed all the URLs yet, thats def a great next task. Aggregate them and figure out the problems. I also think it might be the filename we create, like the file/url fetches |
All the downloading images will have a name