Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependencies install example #165

Merged

Conversation

hyyrdbzm
Copy link
Contributor

@hyyrdbzm hyyrdbzm commented Jan 8, 2025

Issue: #55.
Related issue with more info: puppeteer/puppeteer#12580.

Copy link

google-cla bot commented Jan 8, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@hyyrdbzm
Copy link
Contributor Author

@mathiasbynens JFYI

@mathiasbynens mathiasbynens requested a review from OrKoN January 16, 2025 15:24
@mathiasbynens
Copy link
Member

@OrKoN Could you PTAL?

Copy link
Collaborator

@OrKoN OrKoN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Do you have an example for rpm based distros?

@hyyrdbzm
Copy link
Contributor Author

Thanks! Do you have an example for rpm based distros?

Nope, currently. RPM example will be in next MR, if it happens.

@mathiasbynens mathiasbynens merged commit e0b5d52 into GoogleChromeLabs:main Jan 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants