[mv3] Use globalThis instead of window #1130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch a couple of places that use the "window" object to use "globalThis" instead. The latter is a better equivalent because it works in Manifest V3 Service Workers as well (in a Service Worker, "self" should be used instead of "window"; "globalThis" is an alias to either of those).
emaxx-google
commented
Feb 6, 2024
|
Continuous Integration: All tests passed. |
Fabian-Sommer
approved these changes
Feb 7, 2024
|
Thanks for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch a couple of places that use the "window" object to use "globalThis" instead. The latter is a better equivalent because it works in Manifest V3 Service Workers as well (in a Service Worker, "self" should be used instead of "window"; "globalThis" is an alias to either of those).
This contributes to the effort tracked by #1129.