Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Issue #57 #62

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

someone1
Copy link
Contributor

@someone1 someone1 commented Nov 9, 2015

Moves pipeline from /_ah/pipeline/ to /_pipeline/.
Also fixes up demo code

…e/ to /_pipeline/. Also fixes up demo code
@soundofjw
Copy link

lgtm, just not sure about the architecture decision, reserving that for the googlers.

fwiw: there is nothing in here to ease the transition of queued tasks that are presently pointing to the _ah prefix.

@someone1
Copy link
Contributor Author

someone1 commented Nov 9, 2015

if you keep both entries in your YAML file it should go through fine. both new and old will end up executing on the correct routes, just new pipes will use the new route.

You can also specify the base URL when starting each pipeline, so that way you can explicitly keep all your current pipelines on the old path, and slowly remove the explicit arg for the ones that are not executing when deployed.

@mikelambert
Copy link

@tkaitchuck , any thoughts here? I'm not sure about the best choice of prefix, but I do agree something like this should be committed to ensure this code works on AppEngine Managed VMs (which is the future of AppEngine, from what I hear). Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants