Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add perimeter factory for VPCSC stage #2895

Open
wants to merge 4 commits into
base: fast-dev
Choose a base branch
from

Conversation

karpok78
Copy link

@karpok78 karpok78 commented Feb 14, 2025

A proposal to allow for the management of VPC-SC perimeters in yaml factory.
Project discovery is extended to multiple perimeters thanks to query filtering.
Also adding support for bridge perimeters
The default behavior with a simple single perimeter remains.


Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

Proposal to allow the management of perimeters in yaml factory.
Project discovery is extended to multiple perimeters with query filtering.
Adding support for bridge perimeters
@karpok78 karpok78 changed the title Add perimeter factory Add perimeter factory for VPCSC stage Feb 14, 2025
@ludoo
Copy link
Collaborator

ludoo commented Feb 14, 2025

This is very nice. Bridge perimeters are going away now that egress policies support sources, so we might drop them entirely from the stage.

Give me some time to mull over these changes. :)

@karpok78
Copy link
Author

I forgot to update the schema. I will have a look at it

@juliocc
Copy link
Collaborator

juliocc commented Feb 14, 2025

This is really cool.

I wonder if the core functionality should go in the vpc-sc module?

@ludoo
Copy link
Collaborator

ludoo commented Feb 14, 2025

This is really cool.

I wonder if the core functionality should go in the vpc-sc module?

Ah yes, the vpc-sc factories are all at the module level so the new ones should go there too. Great point.

@karpok78
Copy link
Author

I guess the project directory could also be passed down to the module.
And so the factory could be implemented in the module itself. I'll have a look at it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants