Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add required to blueprint metadata ui proto #1930

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

HuixinLai
Copy link
Contributor

@HuixinLai HuixinLai commented Nov 3, 2023

Add required to blueprint metadata ui proto

Copy link
Collaborator

@g-awmalik g-awmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor nit.

@njlisi - can you stamp it as well?

cli/bpmetadata/proto/bpmetadata_ui.proto Outdated Show resolved Hide resolved
@HuixinLai HuixinLai changed the title feat: add is_required to blueprint metadata ui proto feat: add required to blueprint metadata ui proto Nov 4, 2023
Copy link

@njlisi njlisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@g-awmalik g-awmalik merged commit f245ebf into GoogleCloudPlatform:master Nov 6, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants