feat: update variableValue yaml tag to be plural #2777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apeabody
reviewed
Jan 7, 2025
There was a problem hiding this comment.
Hi @vicentefb
Should this change also trigger a release? https://github.com/GoogleCloudPlatform/cloud-foundation-toolkit/blob/main/cli/Makefile#L4
vicentefb
force-pushed
the
UpdateYamlTag
branch
from
d55442a to
23cf365
Compare
|
Yes @apeabody done, thanks! |
Thanks @vicentefb - I'll defer to @g-awmalik for final approval as this appears to be a potentially breaking change. |
|
I might need to hold this until an update is made to a query as well as the removal of an old field which is not reflected here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
variableValueyaml tag insideDisplayVariableTogglefield needs to be updated to bevariableValuesto be consistent.