chore: fix lint warnings #1544
Merged
chore: fix lint warnings #1544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttosta-google
force-pushed
the
fix-lint-warnings
branch
from
16497f0 to
25cea37
Compare
enocom
reviewed
Sep 22, 2023
jdbc/sqlserver/src/main/java/com/google/cloud/sql/sqlserver/SocketFactory.java
Show resolved
Hide resolved
enocom
approved these changes
Sep 25, 2023
ttosta-google
force-pushed
the
fix-lint-warnings
branch
from
25cea37 to
7f2c75f
Compare
Thanks. I've created the issue #199 for AlloyDB Java |
ttosta-google
force-pushed
the
fix-lint-warnings
branch
from
7f2c75f to
ca7785b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1460
Notes:
Thread.yield();triggers the warning ThreadPriorityCheck. So I replaced it byThread.sleep(0);as they may call same system calls in some platforms. Please let me know if you have any other suggestions.