Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add future reservation support #3227

Merged
merged 1 commit into from
Dec 7, 2024
Merged

Add future reservation support #3227

merged 1 commit into from
Dec 7, 2024

Conversation

abbas1902
Copy link
Contributor

@abbas1902 abbas1902 commented Nov 6, 2024 •
edited
Loading

This PR allows users to add their future reservations into nodesets. Node state is handled by slurmsync and redeployments should no longer be necessary for pre/post reservation nodes.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@abbas1902 abbas1902 requested a review from mr0re1 November 6, 2024 19:43
@abbas1902 abbas1902 force-pushed the to_be_fulfilled branch 4 times, most recently from 153abbd to 3b71826 Compare November 7, 2024 19:00
@abbas1902 abbas1902 marked this pull request as ready for review November 8, 2024 01:09
@abbas1902 abbas1902 force-pushed the to_be_fulfilled branch 9 times, most recently from c88c686 to 953c6a4 Compare November 12, 2024 00:04
@abbas1902 abbas1902 force-pushed the to_be_fulfilled branch 4 times, most recently from fc8de4a to 877bb7c Compare December 6, 2024 19:26
@mr0re1 mr0re1 assigned abbas1902 and unassigned mr0re1 Dec 6, 2024
@abbas1902 abbas1902 assigned mr0re1 and unassigned abbas1902 Dec 6, 2024
@abbas1902 abbas1902 force-pushed the to_be_fulfilled branch 2 times, most recently from d281550 to e52715f Compare December 6, 2024 23:40
@mr0re1 mr0re1 assigned abbas1902 and unassigned mr0re1 Dec 6, 2024
@abbas1902 abbas1902 merged commit 8b4d994 into GoogleCloudPlatform:develop Dec 7, 2024
8 of 61 checks passed
@abbas1902 abbas1902 deleted the to_be_fulfilled branch December 7, 2024 03:35
@abbas1902 abbas1902 added release-key-new-features Added to release notes under the "Key New Features" heading. and removed release-module-improvements Added to release notes under the "Module Improvements" heading. labels Dec 9, 2024
@nick-stroud nick-stroud mentioned this pull request Dec 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mr0re1 mr0re1 mr0re1 approved these changes

Assignees

@abbas1902 abbas1902

Labels
release-key-new-features Added to release notes under the "Key New Features" heading.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abbas1902 @mr0re1