Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a3u-gke-gcs blueprint #3454

Merged

Conversation

samskillman
Copy link
Collaborator

@samskillman samskillman commented Dec 21, 2024

In addition to the blueprint, which gives an opinionated way to mount buckets for training and checkpointing, I modified the gke-persistent-volume to be able to use the mount_options specified in network_storage. It previously just hardcoded implicit-dirs.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@samskillman samskillman added the release-key-new-features Added to release notes under the "Key New Features" heading. label Dec 21, 2024
@samskillman samskillman requested a review from cboneti December 21, 2024 07:46
Copy link
Contributor

@ankitkinra ankitkinra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but will allow storage experts to approve.

We should try to create an e2e integration test for this blueprint as soon as can.

@samskillman samskillman force-pushed the examples/a3u-gke-gcs branch 2 times, most recently from 9dc3cb9 to 443ac98 Compare January 16, 2025 22:10
@samskillman
Copy link
Collaborator Author

Rebased on top of current develop branch. I think this PR is ready for final review.

@samskillman samskillman merged commit 07460df into GoogleCloudPlatform:develop Jan 21, 2025
9 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-key-new-features Added to release notes under the "Key New Features" heading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants