-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a3u-gke-gcs blueprint #3454
Merged
samskillman
merged 15 commits into
GoogleCloudPlatform:develop
from
samskillman:examples/a3u-gke-gcs
Jan 21, 2025
Merged
Add a3u-gke-gcs blueprint #3454
samskillman
merged 15 commits into
GoogleCloudPlatform:develop
from
samskillman:examples/a3u-gke-gcs
Jan 21, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samskillman
added
the
release-key-new-features
Added to release notes under the "Key New Features" heading.
label
Dec 21, 2024
samskillman
force-pushed
the
examples/a3u-gke-gcs
branch
from
December 21, 2024 06:47
ffc05d1
to
c65f2cc
Compare
ighosh98
reviewed
Dec 21, 2024
examples/hypercompute_clusters/a3u-gke-gcs/kueue-configuration.yaml.tftpl
Outdated
Show resolved
Hide resolved
ankitkinra
reviewed
Dec 22, 2024
chengcongdu
reviewed
Dec 26, 2024
saikat-royc
reviewed
Jan 7, 2025
saikat-royc
reviewed
Jan 7, 2025
ankitkinra
reviewed
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but will allow storage experts to approve.
We should try to create an e2e integration test for this blueprint as soon as can.
samskillman
force-pushed
the
examples/a3u-gke-gcs
branch
2 times, most recently
from
January 16, 2025 22:10
9dc3cb9
to
443ac98
Compare
Also adopt latest nccl-rdma installer.
samskillman
force-pushed
the
examples/a3u-gke-gcs
branch
from
January 17, 2025 05:30
443ac98
to
ee88546
Compare
Rebased on top of current |
ighosh98
reviewed
Jan 17, 2025
examples/hypercompute_clusters/a3u-gke-gcs/kueue-configuration.yaml.tftpl
Outdated
Show resolved
Hide resolved
Simplify nemo examples, add instructions to get ramble workspace.
ighosh98
approved these changes
Jan 20, 2025
samskillman
merged commit Jan 21, 2025
07460df
into
GoogleCloudPlatform:develop
9 of 54 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to the blueprint, which gives an opinionated way to mount buckets for training and checkpointing, I modified the gke-persistent-volume to be able to use the mount_options specified in network_storage. It previously just hardcoded implicit-dirs.
Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.