Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code changes to improve how additional networks are passed in A3 ultra blueprint #3529

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

parulbajaj01
Copy link
Contributor

Additional networks are not configured by the user. Moreover, readability is not good. Made changes in gke-a3-ultragpu blueprint to improve code readability. Made changes in gke-cluster, gke-nodepool and vpc modules to pass the correct outputs according to the changes.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@parulbajaj01 parulbajaj01 added the release-improvements Added to release notes under the "Improvements" heading. label Jan 13, 2025
@tpdownes tpdownes added the do-not-merge Block merging of this PR label Jan 13, 2025
@tpdownes
Copy link
Member

Adding do not merge label until we resolve internal discussions

@annuay-google annuay-google marked this pull request as draft January 13, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge Block merging of this PR release-improvements Added to release notes under the "Improvements" heading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants