Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove expanded blueprint from A3U Slurm solution #3555

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

tpdownes
Copy link
Member

The placement of this file inside the cluster was primarily for development purposes and it is not being updated upon repeated invocations of gcluster deploy. We should remove the file in favor of an approach with guaranteed synchronization.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@tpdownes tpdownes added the release-chore To not include into release notes label Jan 17, 2025
@tpdownes tpdownes self-assigned this Jan 17, 2025
@tpdownes tpdownes requested a review from rohitramu January 17, 2025 17:16
@tpdownes tpdownes assigned rohitramu and unassigned tpdownes Jan 17, 2025
@tpdownes tpdownes marked this pull request as ready for review January 17, 2025 17:16
@rohitramu rohitramu assigned tpdownes and unassigned rohitramu Jan 17, 2025
@tpdownes tpdownes merged commit 1792fb8 into GoogleCloudPlatform:develop Jan 17, 2025
11 of 55 checks passed
@tpdownes tpdownes deleted the remove_expanded_bp branch January 17, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-chore To not include into release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants