Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove slurm portion of dependabot config #3559

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

abbas1902
Copy link
Contributor

The requirements.txt here is not actually used by slurm (https://github.com/GoogleCloudPlatform/slurm-gcp/blob/master/scripts/requirements.txt is the one that is actually used when building images). Removing it from dependabot's config so it no longer generates PRs to update the packages.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@abbas1902 abbas1902 added the release-chore To not include into release notes label Jan 17, 2025
Copy link
Collaborator

@mr0re1 mr0re1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update Makefile:install-dev-deps
and tools/cloud-build/images/test-runner/Dockerfile by pointing to right file in slurm-gcp repo.

@abbas1902 abbas1902 assigned mr0re1 and abbas1902 and unassigned mr0re1 Jan 17, 2025
@abbas1902 abbas1902 force-pushed the independent branch 5 times, most recently from 7005e14 to 2759fb8 Compare January 17, 2025 23:11
@abbas1902 abbas1902 added the do-not-merge Block merging of this PR label Jan 17, 2025
@abbas1902 abbas1902 removed the do-not-merge Block merging of this PR label Jan 18, 2025
@abbas1902 abbas1902 assigned mr0re1 and unassigned abbas1902 Jan 18, 2025
@mr0re1 mr0re1 assigned abbas1902 and unassigned mr0re1 Jan 18, 2025
@abbas1902 abbas1902 changed the title Remove requirements.txt and slurm portion of dependabot config Remove slurm portion of dependabot config Jan 21, 2025
@abbas1902 abbas1902 merged commit 7a29a7a into GoogleCloudPlatform:develop Jan 21, 2025
11 of 56 checks passed
@abbas1902 abbas1902 deleted the independent branch January 21, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-chore To not include into release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants