Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable queued provisioning on gke nodepool #3568

Closed
wants to merge 2 commits into from
Closed

enable queued provisioning on gke nodepool #3568

wants to merge 2 commits into from

Conversation

SwarnaBharathiMantena
Copy link
Contributor

Enable queued provisioning on gke nodepool.

  • Add the enable_queued_provisioning boolean variable.
  • Update google-beta provider version to 5.21 (associated with queued_provisioning GA)
  • Add precondition to ensure placement_policy is not set to COMPACT when enable_queued_provisioning is true.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@SwarnaBharathiMantena SwarnaBharathiMantena added the release-key-new-features Added to release notes under the "Key New Features" heading. label Jan 21, 2025
@SwarnaBharathiMantena SwarnaBharathiMantena force-pushed the swarnabm/nodepool_enable_queued_provisioning branch from b3207b7 to 31269c6 Compare January 23, 2025 11:28
@SwarnaBharathiMantena SwarnaBharathiMantena removed the request for review from samskillman January 23, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annuay-google annuay-google annuay-google left review comments

Assignees
No one assigned
Labels
release-key-new-features Added to release notes under the "Key New Features" heading.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SwarnaBharathiMantena @annuay-google @mr0re1