Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert PR 3406 #3573

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Revert PR 3406 #3573

merged 1 commit into from
Jan 22, 2025

Conversation

ankitkinra
Copy link
Contributor

This pr reverts the merge commit 81e63e6 for PR3406

This is due to XPK having issues running gcluster in container environment

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@ankitkinra
Revert "Merge pull request GoogleCloudPlatform#3406 from mohitchauras…
fcc2d8d 
…ia91/fix-gke-module-provider"

This reverts commit 81e63e6, reversing
changes made to e17bb15.
@ankitkinra ankitkinra added the release-bugfix Added to release notes under the "Bug fixes" heading. label Jan 21, 2025
@annuay-google annuay-google self-requested a review January 22, 2025 09:00
annuay-google
annuay-google approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@annuay-google annuay-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, all GKE ITs passing

@annuay-google
Copy link
Contributor

Verified the changes over docker once again, merging

@annuay-google annuay-google merged commit a9dd634 into GoogleCloudPlatform:main Jan 22, 2025
19 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohitchaurasia91 mohitchaurasia91 mohitchaurasia91 approved these changes

@annuay-google annuay-google annuay-google approved these changes

Assignees

@ankitkinra ankitkinra

@tpdownes tpdownes

@RachaelSTamakloe RachaelSTamakloe

Labels
release-bugfix Added to release notes under the "Bug fixes" heading.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ankitkinra @annuay-google @mohitchaurasia91 @tpdownes @RachaelSTamakloe