Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test for a3ultra-vm.yaml #3579

Conversation

RachaelSTamakloe
Copy link
Collaborator

@RachaelSTamakloe RachaelSTamakloe commented Jan 22, 2025

This PR adds an integration test for the a3ultra-vm.yaml blueprint. The integration test deploys the a3ultra-vm.yaml blueprint and runs nvidia-smi on remote_node: "{{ hostname_prefix }}-0".

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@RachaelSTamakloe RachaelSTamakloe added the release-improvements Added to release notes under the "Improvements" heading. label Jan 22, 2025
Copy link
Member

@tpdownes tpdownes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please split the changes to modules/compute/vm-instance/* into a separate PR? Additionally, we've now introduced a situation where the following input variables may have user confusion:

  • var.spot
  • var.reservation_name
  • var.reservation_bound

Let's discuss offline how to guide away from user confusion.

modules/compute/vm-instance/main.tf Outdated Show resolved Hide resolved
Copy link
Member

@tpdownes tpdownes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved anticipating the removal of changes to vm-instance module after #3588 is merged.

@RachaelSTamakloe RachaelSTamakloe merged commit eede98d into GoogleCloudPlatform:develop Jan 27, 2025
9 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-improvements Added to release notes under the "Improvements" heading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants