-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration test for a3ultra-vm.yaml #3579
Add integration test for a3ultra-vm.yaml #3579
Conversation
2f5e7fd
to
eabcb68
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please split the changes to modules/compute/vm-instance/* into a separate PR? Additionally, we've now introduced a situation where the following input variables may have user confusion:
- var.spot
- var.reservation_name
- var.reservation_bound
Let's discuss offline how to guide away from user confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved anticipating the removal of changes to vm-instance module after #3588 is merged.
eabcb68
to
4764eea
Compare
4764eea
to
c5459c8
Compare
eede98d
into
GoogleCloudPlatform:develop
This PR adds an integration test for the a3ultra-vm.yaml blueprint. The integration test deploys the a3ultra-vm.yaml blueprint and runs
nvidia-smi
onremote_node: "{{ hostname_prefix }}-0"
.Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.