Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add H4d vm integration tests #3621

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Add H4d vm integration tests #3621

merged 1 commit into from
Feb 7, 2025

Conversation

abbas1902
Copy link
Contributor

@abbas1902 abbas1902 commented Feb 1, 2025 •
edited
Loading

Added basic H4d vm integration test that also tests mounts. Successful cloud build

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@abbas1902 abbas1902 added the release-chore To not include into release notes label Feb 1, 2025
@abbas1902 abbas1902 self-assigned this Feb 1, 2025
@abbas1902 abbas1902 marked this pull request as ready for review February 3, 2025 17:42
@abbas1902 abbas1902 requested a review from rohitramu February 3, 2025 17:43
@abbas1902 abbas1902 assigned rohitramu and abbas1902 and unassigned abbas1902 and rohitramu Feb 3, 2025
@abbas1902 abbas1902 assigned rohitramu and unassigned abbas1902 Feb 4, 2025
@rohitramu rohitramu assigned abbas1902 and unassigned rohitramu Feb 4, 2025
@abbas1902 abbas1902 merged commit e664b12 into GoogleCloudPlatform:develop Feb 7, 2025
10 of 56 checks passed
@abbas1902 abbas1902 deleted the integration-test branch February 7, 2025 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitramu rohitramu rohitramu approved these changes

Assignees

@abbas1902 abbas1902

Labels
release-chore To not include into release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abbas1902 @rohitramu