Added capability to provide metadata prefetch memory request and limits in pod spec #472

chrisThePattyEater · 2025-02-12T17:41:24Z

Added capability to provide metadata prefetch memory request and limits in pod spec to fuse csi annotations Additionally added unit tests verifying changes.

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:
This pr adds functionality to allow fuse driver users to provide custom metadata prefetch sidecar memory and limits. The changes add additional annotations and variables to extract prefetch limits and requests if provided and uses those values for the prefetch sidecar config if provided. Otherwise it uses default values

Which issue(s) this PR fixes:

Fixes https://b.corp.google.com/issues/385198703

Does this PR introduce a user-facing change?:

pkg/webhook/sidecar_spec.go

cmd/webhook/main.go

hime · 2025-02-12T23:10:20Z

pkg/webhook/config.go

 	}
 }

 func FakeConfig() *Config {
 	fakeImage1 := "fake-repo/fake-sidecar-image:v999.999.999-gke.0@sha256:c9cd4cde857ab8052f416609184e2900c0004838231ebf1c3817baa37f21d847"
 	fakeImage2 := "fake-repo/fake-sidecar-image:v888.888.888-gke.0@sha256:c9cd4cde857ab8052f416609184e2900c0004838231ebf1c3817baa37f21d847"

-	return LoadConfig(fakeImage1, fakeImage2, "Always", "250m", "250m", "256Mi", "256Mi", "5Gi", "5Gi")
+	return LoadConfig(fakeImage1, fakeImage2, "Always", "250m", "250m", "256Mi", "256Mi", "5Gi", "5Gi", "-1", "-1")


Try to use relevant values when testing your changes. If the resource is memory, then use memory units.

pkg/webhook/mutatingwebhook.go

pkg/webhook/sidecar_spec.go

hime · 2025-02-12T23:30:05Z

pkg/webhook/mutatingwebhook_test.go

@@ -226,6 +226,87 @@ func TestPrepareConfig(t *testing.T) {
 			},
 			expectErr: false,
 		},
+		{


can we add a test that doesn't provide limits and verify we use defaults?

isn't that every other test that doesn't provide limits

You're right. In that case the current tests should be failing because the wantConfig should contain the default values.

pkg/webhook/injection.go

…ts to fuse csi annotations> Additionally added unit tests verifying changes.

chrisThePattyEater force-pushed the fuechr/metadata-prefetch-memory-override branch 2 times, most recently from ddbec01 to ae919db Compare February 12, 2025 17:59