Disable sidecar metrics server when metrics are disabled. #476
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I1837db06f6f9118ae7c942db7c6d2ea24d2f866b
hime
requested review from
kislaykishore
and removed request for
kislaykishore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
When we disable metrics, we still enable the gke gcsfuse sidecar metrics collector server endpoint to collect metrics. The intended behavior is to disable all metrics serviced.
Which issue(s) this PR fixes:
Fixes #
Bug found while going through the code.
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
/cc @kislaykishore