Recreate MRD in case of any error #2970
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhishek10004
added
execute-perf-test
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2970 +/- ##
==========================================
- Coverage 75.21% 75.14% -0.07%
==========================================
Files 125 125
Lines 17734 17745 +11
==========================================
- Hits 13339 13335 -4
- Misses 3831 3843 +12
- Partials 564 567 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kislaykishore
requested review from
a team,
gargnitingoogle and
tritone
and removed request for
a team and
gargnitingoogle
| @@ -220,6 +232,9 @@ func (mrdWrapper *MultiRangeDownloaderWrapper) Read(ctx context.Context, buf []b | |||
|
|
|||
| if e != nil && e != io.EOF { | |||
| e = fmt.Errorf("Error in Add Call: %w", e) | |||
| mrdWrapper.muCreateMRD.Lock() | |||
There was a problem hiding this comment.
Couple of things:
- We shouldn't create mrd on every error. Should be created only when mrd is closed by go-sdk.
- If there are x callbacks failed on the mrd, then we end up creating mrd x number of times even with the muCreateMRD lock. This is the thing which we wanted to avoid in the first place and didn't take this route.
Lets work with go-sdk in coming up with the right solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to ensure MRD is recreated if any error is thrown from the Add call as well. Currently, after successful recreation of MRD, we are not recreating it.
Using a new variable to determine creation of MRD (instead of setting it to nil) to simplify the code (i.e. to prevent an additional mutex lock before calling add)
Performance testing: Tested random read with 50 threads for 1M/128K block size and there is no regression. Also tested the parallel read scenario (50 threads randomly reading from the same file) and there's no regression in this scenario as well.
b/394500981