Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to golang 1.24.0 #3006

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

gargnitingoogle
Copy link
Collaborator

@gargnitingoogle gargnitingoogle commented Feb 18, 2025

Description

Link to the issue in case of a bug fix.

b/397172415

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

@gargnitingoogle gargnitingoogle requested review from Tulsishah and a team as code owners February 18, 2025 11:13
@kislaykishore kislaykishore requested review from a team, tritone and BrennaEpp and removed request for a team, tritone and BrennaEpp February 18, 2025 11:13
@gargnitingoogle gargnitingoogle added the execute-integration-tests Run only integration tests label Feb 18, 2025
@gargnitingoogle gargnitingoogle changed the title golang 1.24.0 Upgrade to golang 1.24.0 Feb 18, 2025
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.46%. Comparing base (d699f24) to head (79e4e73).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3006      +/-   ##
==========================================
- Coverage   75.49%   75.46%   -0.03%     
==========================================
  Files         126      126              
  Lines       17731    17731              
==========================================
- Hits        13386    13381       -5     
- Misses       3788     3792       +4     
- Partials      557      558       +1     
Flag Coverage Δ
unittests 75.46% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gargnitingoogle
Copy link
Collaborator Author

This PR is repeatedly failing monitoring tests with errors:

=== RUN   TestPromOCSuite
{"timestamp":{"seconds":1739941080,"nanos":867403612},"severity":"INFO","message":"Building build_gcsfuse at /tmp/gcsfuse_integration_tests3469722005/build_gcsfuse"}
{"timestamp":{"seconds":1739941103,"nanos":43989002},"severity":"INFO","message":"Building gcsfuse into /tmp/gcsfuse_readwrite_test_2993499574"}
=== RUN   TestPromOCSuite/TestFsOpsErrorMetrics
=== RUN   TestPromOCSuite/TestListMetrics
    prom_test.go:218: 
        	Error Trace:	/tmpfs/src/github/gcsfuse/tools/integration_tests/monitoring/prom_test.go:136
        	            				/tmpfs/src/github/gcsfuse/tools/integration_tests/monitoring/prom_test.go:144
        	            				/tmpfs/src/github/gcsfuse/tools/integration_tests/monitoring/prom_test.go:218
        	Error:      	Received unexpected error:
        	            	Get "http://localhost:9191/metrics": dial tcp 127.0.0.1:9191: connect: connection refused
        	Test:       	TestPromOCSuite/TestListMetrics
=== RUN   TestPromOCSuite/TestReadMetrics
    prom_test.go:228: 
        	Error Trace:	/tmpfs/src/github/gcsfuse/tools/integration_tests/monitoring/prom_test.go:136
        	            				/tmpfs/src/github/gcsfuse/tools/integration_tests/monitoring/prom_test.go:144
        	            				/tmpfs/src/github/gcsfuse/tools/integration_tests/monitoring/prom_test.go:228
        	Error:      	Received unexpected error:
        	            	Get "http://localhost:9191/metrics": dial tcp 127.0.0.1:9191: connect: connection refused
        	Test:       	TestPromOCSuite/TestReadMetrics
=== RUN   TestPromOCSuite/TestStatMetrics
    prom_test.go:200: 
        	Error Trace:	/tmpfs/src/github/gcsfuse/tools/integration_tests/monitoring/prom_test.go:136
        	            				/tmpfs/src/github/gcsfuse/tools/integration_tests/monitoring/prom_test.go:144
        	            				/tmpfs/src/github/gcsfuse/tools/integration_tests/monitoring/prom_test.go:200
        	Error:      	Received unexpected error:
        	            	Get "http://localhost:9191/metrics": dial tcp 127.0.0.1:9191: connect: connection refused
        	Test:       	TestPromOCSuite/TestStatMetrics
--- FAIL: TestPromOCSuite (415.43s)
    --- PASS: TestPromOCSuite/TestFsOpsErrorMetrics (2.11s)
    --- FAIL: TestPromOCSuite/TestListMetrics (1.89s)
    --- FAIL: TestPromOCSuite/TestReadMetrics (4.72s)
    --- FAIL: TestPromOCSuite/TestStatMetrics (24.63s)

and similar.

@kislaykishore kislaykishore force-pushed the gargnitin/golang-1.24.0 branch from 13ab4c8 to f16e6c1 Compare February 19, 2025 09:37
@gargnitingoogle gargnitingoogle force-pushed the gargnitin/golang-1.24.0 branch 3 times, most recently from c5122e4 to 51f8dc3 Compare February 21, 2025 05:53
@gargnitingoogle
Copy link
Collaborator Author

@kislaykishore this is failing now with timeout in emulator tests consistently. This wasn't failing earlier. Is this related to your change?

cc @Tulsishah .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-integration-tests Run only integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant