-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make create idempotent #15
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
echo "${TFVARS_FILE} already exists, skipping generation."
^ Instead of skipping generation, should we remove and generate a new one just in case the existing one has different data.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: JonahBraun The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@elung-anthos: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch? |
make create
Can now be run twice in a row without error. Also, a create can be run after a teardown. To test:I recommend we also make
make teardown
idempotent. Currently it fails if the terraform project has not been initialized. However, it should detect this and continue to clean any other remains of of past use, deleting terraform.tfvars, etc. and exiting cleanly.